fix: disable fof/redis settings cache to avoid circular boot dependency (#7)
Some checks failed
GB Redis Setup PHP / run (push) Has been cancelled
GB Redis Setup JS / run (push) Has been cancelled

fof/redis >=1.1 introduces a `settings` service that replaces
SettingsRepositoryInterface with a Redis-backed caching layer.
Enabling it here creates a circular dependency: this extension reads
settings to decide which Redis services to enable, but with the
settings cache active those reads require Redis to already be wired.

Always disable the `settings` service when delegating to fof/redis.
Also fixes a cast-precedence bug in the database env var helpers
where `(int) getenv(...) ? getenv(...) : N` applied the cast to the
ternary condition rather than the result, causing REDIS_DATABASE_*=0
to return the default instead of 0.

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
IanM
2026-03-03 17:29:17 +00:00
committed by GitHub
parent 4f261dbee4
commit 77ad7422e7
3 changed files with 23 additions and 9 deletions

View File

@@ -20,7 +20,7 @@
"require": {
"php": "^8.1",
"flarum/core": "^1.8.5",
"fof/redis": "^1.0"
"fof/redis": "^1.1.4"
},
"authors": [
{